CI: Unpin Cython #54784
Merged
CI: Unpin Cython #54784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
added
CI
|
Something is going wrong on the Cython end I think ... Pushing this to 2.1.1. |
|
I'm gonna merge to get Cython unpinned for now. Happy to address followups in another PR. |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Sep 16, 2023
|
@lithomas1 - We've been pinning Cython in the ASVs; should this be unpinned too? pandas/asv_bench/asv.conf.json Line 45 in 753d0ed |
|
Ah - maybe I'm confused. Looks like we're only unpinning Cython in the CI? |
|
Yeah, ASVs have to stay pinned since there was a perf regression with Cython 3 (so we'd have spurious regressions if we unpinned). |
lithomas1
added a commit
that referenced
this pull request
Sep 16, 2023
Backport PR #54784: CI: Unpin Cython Co-authored-by: Thomas Li <[email protected]>
hedeershowk
pushed a commit
to hedeershowk/pandas
that referenced
this pull request
Sep 20, 2023
* CI: Unpin Cython * Update actions-311-numpydev.yaml * disable cache for now * try bumping meson * bump meson everywhere --------- Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.